Sara/citybuilder
Watch
1
0
Fork
You've already forked citybuilder
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Never spawn agents on a road island disconnected from the main network #6

Open
Danny wants to merge 1 commit from danny/no-spawn-on-disconnected-roads into master AGit
pull from: danny/no-spawn-on-disconnected-roads
merge into: Sara:master
Conversation 0 Commits 1 Files changed 1 +97 -3
Danny commented 2026-10-08 05:01:47 -04:00
Collaborator
Copy link

road_tiles was every live road tile with no regard for connectivity, so a
player-built stub with no link back to the network could get an agent
spawned on it. That agent can never be routed anywhere real and sits there
forever, since reassign_idle_agents silently skips a failed route rather
than erroring. refresh_road_tiles now keeps only the largest island from
RoadGraph::islands() (already-tested BFS, no new graph work needed), and
spawn_agent_now gets an explicit membership check for the same reason.

road_tiles was every live road tile with no regard for connectivity, so a player-built stub with no link back to the network could get an agent spawned on it. That agent can never be routed anywhere real and sits there forever, since reassign_idle_agents silently skips a failed route rather than erroring. refresh_road_tiles now keeps only the largest island from RoadGraph::islands() (already-tested BFS, no new graph work needed), and spawn_agent_now gets an explicit membership check for the same reason. 
road_tiles was every live road tile with no regard for connectivity, so a
player-built stub with no link back to the network could get an agent
spawned on it. That agent can never be routed anywhere real and sits there
forever, since reassign_idle_agents silently skips a failed route rather
than erroring. refresh_road_tiles now keeps only the largest island from
RoadGraph::islands() (already-tested BFS, no new graph work needed), and
spawn_agent_now gets an explicit membership check for the same reason.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/6/head:danny/no-spawn-on-disconnected-roads
git switch danny/no-spawn-on-disconnected-roads

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff danny/no-spawn-on-disconnected-roads
git switch danny/no-spawn-on-disconnected-roads
git rebase master
git switch master
git merge --ff-only danny/no-spawn-on-disconnected-roads
git switch danny/no-spawn-on-disconnected-roads
git rebase master
git switch master
git merge --no-ff danny/no-spawn-on-disconnected-roads
git switch master
git merge --squash danny/no-spawn-on-disconnected-roads
git switch master
git merge --ff-only danny/no-spawn-on-disconnected-roads
git switch master
git merge danny/no-spawn-on-disconnected-roads
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Sara/citybuilder!6
No description provided.